Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2020 #12

Merged
merged 8 commits into from
Jun 30, 2020
Merged

#2020 #12

merged 8 commits into from
Jun 30, 2020

Conversation

kmulvey
Copy link
Contributor

@kmulvey kmulvey commented Jun 30, 2020 •
edited by ajaxisme
Loading

go mod, v2 cli, linting

@kmulvey kmulvey marked this pull request as ready for review June 30, 2020 16:14
@kmulvey kmulvey requested review from tkonya and ajaxisme June 30, 2020 16:14
@ajaxisme
Copy link

What does this PR do?

@kmulvey
Copy link
Contributor Author

kmulvey commented Jun 30, 2020

go mod, v2 cli, linting

ajaxisme
ajaxisme approved these changes Jun 30, 2020
View reviewed changes
Copy link

@ajaxisme ajaxisme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things to look into

  1. figure out circle ci integration
  2. merge this into go-changes

@kmulvey kmulvey merged commit 7020fda into master Jun 30, 2020
@kmulvey kmulvey deleted the feature/gomod branch June 30, 2020 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajaxisme ajaxisme ajaxisme approved these changes

@tkonya tkonya Awaiting requested review from tkonya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kmulvey @ajaxisme